Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add /srv/vvv #2328

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

WIP: Add /srv/vvv #2328

wants to merge 7 commits into from

Conversation

tomjn
Copy link
Member

@tomjn tomjn commented Dec 27, 2020

Switch from /vagrant to /srv/vvv

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

@tomjn tomjn added this to the 3.6 milestone Dec 27, 2020
@tomjn tomjn mentioned this pull request Dec 27, 2020
Merged
@tomjn tomjn marked this pull request as ready for review December 28, 2020 18:52
@tomjn tomjn requested a review from a team December 29, 2020 17:11
Mte90
Mte90 requested changes Dec 30, 2020
View reviewed changes
Copy link
Member

@Mte90 Mte90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20201230_162403

It is crashing to me the provision with that branch.

@Mte90 Mte90 self-requested a review January 19, 2021 17:38
Mte90
Mte90 previously approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@Mte90 Mte90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and no errors

@tomjn tomjn modified the milestones: 3.6, 3.7 Mar 7, 2021
@tomjn tomjn mentioned this pull request Apr 6, 2021
Merged
@Mte90 Mte90 self-requested a review April 6, 2021 11:42
@Mte90
Copy link
Member

Mte90 commented Apr 6, 2021

Screenshot_20210406_134256
I got this I guess that this works for new VM.

@tomjn
Copy link
Member Author

tomjn commented Apr 6, 2021

@Mte90 that shouldn't have happened, looks like there's still work to be done here

@Mte90
Copy link
Member

Mte90 commented Apr 7, 2021

As I can see that folder get root permissions instead the others have vagrant/vagrant:

Screenshot_20210407_122030

I think that a chown when the folder is created should be enough @tomjn

@Mte90 Mte90 requested a review from a team June 4, 2021 10:21
@Mte90
Copy link
Member

Mte90 commented Jun 4, 2021

I think that is the case that someone else test that PR.

evertiro
evertiro requested changes Jun 6, 2021
View reviewed changes
Copy link
Contributor

@evertiro evertiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. This still fails with the SCP error (actually, the only change made after the SCP error was discovered was a merge).

@tomjn tomjn modified the milestones: 3.7, 3.8 Jul 27, 2021
@Mte90
Copy link
Member

Mte90 commented Jul 22, 2022

I will do some tests for this to moving on, I just forgot it...

@Mte90
Copy link
Member

Mte90 commented Jul 28, 2022

So I tested it and a vagrant provision generate this.

 ⚠ ! Running additional Vagrant code in Customfile located at /home/www/VVV/Customfile
 ⚠ ! Official support is not provided for this feature, it is assumed you are proficient with vagrant

 ⚠ ! Finished running Customfile, resuming normal vagrantfile execution

There are errors in the configuration of this machine. Please fix
the following errors and try again:

shell provisioner:
* Shell provisioner `args` must be a string or array.

@tomjn tomjn modified the milestones: 3.8, 311 Sep 10, 2022
@tomjn tomjn marked this pull request as draft November 13, 2022 17:47
@tomjn
Copy link
Member Author

tomjn commented Nov 13, 2022

converted this to a draft, I want to see the end result of the vagrantfile changes before adjusting this

@tomjn tomjn changed the title Add /srv/vvv WIP: Add /srv/vvv Nov 13, 2022
@tomjn tomjn modified the milestones: 3.11, 3.13 Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaggiorato msaggiorato msaggiorato requested changes

@evertiro evertiro evertiro requested changes

@Mte90 Mte90 Awaiting requested review from Mte90

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
3.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomjn @Mte90 @evertiro @msaggiorato