Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename VSCodium to Codium #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stripedpajamas
Copy link
Member

Closes #193

Additional actions required to merge:

  • update Azure release pipeline glob pattern (currently is set to VS*)

Will not be merging until I've confirmed the binaries build and look good on my branch (releases, builds)

@stripedpajamas
Copy link
Member Author

stripedpajamas commented Nov 24, 2019

I think this PR takes it a bit too far; the settings/config folders were fresh, so when I downloaded + installed Codium from my branch, it had none of my modified settings / keymaps. I am on a Mac, so this is because Library / Application Support / VSCodiumLibrary / Application Support / Codium.

On the other hand, Visual Studio Code uses Library / Application Support / Code, which would imply we should move forward with using Codium here as well. The downside is it's a very disruptive change to existing users.

@thisiskeithb
Copy link

thisiskeithb commented Dec 20, 2019

Adding a note about the change/where to move settings on the releases page should suffice.

And honestly, if someone went through all the effort to install VSCodium instead of VSCode, they should be able to handle moving settings over 🙂

@janniks
Copy link
Contributor

janniks commented Feb 10, 2020

👋 wanted to check in here - is there something I could help out with?

@stripedpajamas
Copy link
Member Author

Sorry for the huge delay on this everyone. I don't have much time for VSCodium work these days.

This PR can be merged after conflicts are resolved and after I (or anyone) has done some additional testing around the auto-update experience. Specifically I'm wondering what happens if the next release is cut as Codium; do users with autoupdate enabled (such as myself) automatically download + install it? If so, my suspicion is we'll see a dozen new issues logged because "after update all my settings/themes disappeared" (despite any notes we may put on the Releases page).

I'd rather think through some ways to avoid that disruption if possible. If there's no way around it, I'll opt for clear documentation around what to do (copy settings/themes to new dir) and noisy messaging on the Releases page and README.

@guruathwal
Copy link

Instead of putting any note/Instruction anywhere, will it not be better to show a data migration progress and move the data from old directories(if found) to new ones or rename the old ones?

@LRNZ09
Copy link

LRNZ09 commented Oct 12, 2020

@stripedpajamas any news on this PR?

@jacksongoode
Copy link

Any plan on moving this forward?

@drupol
Copy link

drupol commented Nov 19, 2020

Conflicts needs to be fixed. As @stripedpajamas doesn't have time to invest in this anymore, maybe it would be better to create another PR with people willing to fix this?

@daiyam
Copy link
Member

daiyam commented Jul 15, 2021

@stripedpajamas Do you want me to make the changes?

@stripedpajamas
Copy link
Member Author

@daiyam since this is a big disruptive change, I think it would be better to first introduce a way for non-Github-users to be notified of "big disruptive changes", e.g. #599 . My idea is that if we sideload VSCodium changelogs into the existing release notes from MS, we could make this change and provide the notification + workarounds / next steps to the users that way. Thoughts ?

@daiyam
Copy link
Member

daiyam commented Jul 16, 2021

@stripedpajamas I agree 100%. To customize the welcome page is a good idea.
Also, we would need an action plan to rename or migrate the app in the different app stores for linux, macos or windows...

@daiyam
Copy link
Member

daiyam commented Jul 16, 2021

We can also add a modal (with vscode.window.showWarningMessage) to show a message that the app will be renamed.

@daiyam
Copy link
Member

daiyam commented Jul 17, 2021

Here a list of app stores where you can find VSCodium. It would be good if we could automate the publication.

Linux

Name URL Maintainer Renameable Source
Snap https://snapcraft.io/ https://github.com/popey https://github.com/snapcrafters/codium
Deb https://gitlab.com/paulcarroty/vscodium-deb-rpm-repo/ https://gitlab.com/paulcarroty https://wiki.debian.org/RenamingPackages
RPM https://gitlab.com/paulcarroty/vscodium-deb-rpm-repo/ https://gitlab.com/paulcarroty https://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages
Nix https://github.com/NixOS/nixpkgs/tree/master/pkgs/applications/editors/vscode
Arch https://aur.archlinux.org/ sperg512 https://aur.archlinux.org/packages/vscodium-bin/
Flatpak https://flathub.org/home https://github.com/flathub/com.vscodium.codium
AppImage https://github.com/VSCodium/vscodium/blob/master/VSCodium-AppImage-Recipe.yml

macOS

Name URL Maintainer Renameable Source
Homebrew https://brew.sh/ https://docs.brew.sh/Rename-A-Formula https://github.com/Homebrew/homebrew-cask/blob/master/Casks/vscodium.rb

Windows

Name URL Maintainer Renameable Source
winget https://winget.run/ https://github.com/microsoft/winget-pkgs/tree/master/manifests/v/VSCodium/VSCodium
Chocolatey https://chocolatey.org/ https://community.chocolatey.org/profiles/Thilas https://github.com/Thilas/chocolatey-packages/tree/master/vscodium
Scoop https://scoop.sh/ https://github.com/Ash258 https://github.com/lukesampson/scoop-extras/blob/master/bucket/vscodium.json

@stripedpajamas
Copy link
Member Author

I think wherever something is named "vscode" we can leave ours as "vscodium" (are there any such examples?), and wherever something is named "code" we will have "codium" (e.g. snapcraft, the local binary). For places where Microsoft's name is "visual studio code", I'm not sure what ours should be, e.g. brew: https://formulae.brew.sh/cask/visual-studio-code, but I would lean towards vscodium here to be "nearby" the MS version. Discussion welcome.

Also I think the RPM/DEB part is already done (at least the README is instructing to install codium -- https://gitlab.com/paulcarroty/vscodium-deb-rpm-repo/).

@GitMensch
Copy link
Collaborator

Discussion welcome.

No discussion here, I just want to say I totally agree with:

  • the name change as outlined
  • the option to add to / replace the welcome page (replace because in the past there often was showcasing for "Visual Studio Code"-only extensions and proprietary "services" [and I often get asked why this does not works and if people should install vscode instead])

@coxackie
Copy link

coxackie commented Sep 2, 2021

... still?

@GitMensch
Copy link
Collaborator

@daiyam Can you work on automated adjusting of the welcome page and the option to one-time raise an information on update?

This would allow to "get the news out". I suggest to postpone the actual name change to a specific version up-front which is not "too short" so people have a chance to see it even when they don't open VSCodium/update it very regularly. Maybe specifying "executable name will be changed to codium in version 1.68 (and then push the changes on current master again to have it ready) until 1.67, so we're quite sure that 1.68 should have no issue (or all that one main version before/later).

@paulcarroty
Copy link
Collaborator

@GitMensch I think it's too late. The project is very well known to change his name. It feels like renaming 'ABBA' to 'BBA'.

executable name will be changed to codium

Done.

@GitMensch
Copy link
Collaborator

The project is very well known to change his name. It feels like renaming 'ABBA' to 'BBA'.

I'm not sure about "too late" actually and am in favor of dropping the "VS" prefix.
If we find "yes, that's too late", then this issue should be closed.

We may could also use the (currently not available) adjusted welcome page and extra info message to point to a new survey to receive user feedback - without such information to the users it doesn't make any sense to create a survey issue again.

executable name will be changed to codium

Done.

Ah, that's true for any environment but Win32 I guess (there are codium and codium.bat under "bin", but the executable is still named VSCodium.exe) - if this is only different on Win32 then I definitely would suggest to adjust that.

@trymeouteh
Copy link

I am in favor of renaming the app to codium

@wallrik
Copy link

wallrik commented Jun 12, 2022

When GitHub announced they're killing off Atom I started looking into VSCode and found this project instead. When can this change be implemented? 😇 From what I've read here there doesn't really seem to be any reason not to do it?

As a new user I was confused why it was named Visual Studio Codium.

@ioquatix
Copy link

I also agree with changing the name, and I want to add another point, "VS" meaning "Visual Studio" is, from what I can tell, a trademark of Microsoft. So even more reason to distance from that convention.

@ghost
Copy link

ghost commented Jun 28, 2022

@ioquatix I agree. "VSCodium" has probably the VS trademarked by MS.

@ghost
Copy link

ghost commented Jun 28, 2022

@stripedpajamas any news on this PR?

This is an inactive PR, therefore it's not really news now.

@cntrump
Copy link

cntrump commented Oct 27, 2022

but Codium.com is registed.

@Alex313031
Copy link

Alex313031 commented Apr 30, 2023

@stripedpajamas @thisiskeithb @janniks @guruathwal @LRNZ09 I have made a fork, which has four differences from here.

  1. Name is changed to just Codium
  2. Compiler optimizations for node gyp (which I might make a PR on)
  3. Icon is the default one from code-oss, which I think looks better than vscode or vscodium
  4. Added a new patch for the welcome page to have correct branding (which I might also make a PR on)

https://github.com/Alex313031/codium

I make builds for Linux and Windows

@GitMensch
Copy link
Collaborator

@stripedpajamas @thisiskeithb @janniks @guruathwal @LRNZ09 I have made a fork, which has four differences from here.

1. Name is changed to just Codium

2. Compiler optimizations for node gyp (which I might make a PR on)

3. Icon is the default one from code-oss, which I think looks better than vscode or vscodium

4. Added a new patch for the welcome page to have correct branding (which I might also make a PR on)

https://github.com/Alex313031/codium

Please make separate PRs for 1, 2 and 4 and outline a bit more in the README where the differences are (I suggest to do this relative at the top).

@daiyam
Copy link
Member

daiyam commented Apr 30, 2023

Please make separate PRs for 1, 2 and 4 and outline a bit more in the README where the differences are (I suggest to do this relative at the top).

I don't think 1 isn't necessary since it's his fork name.

Personally, while we don't have any trademark or anything on codium, I don't think it's fair or creative to name a fork just codium. (PS: on Linux, VSCodium binary is also named codium, so there will be conflict when both are installed...)

@Alex313031
Copy link

@GitMensch @daiyam Ok will do. Also, no it wont conflict, because I made my codium fork install into a different dir, use a different user profile folder, and a different GUID (on windows) to prevent exactly this and so that vscode, vscodium, and codium could all be installed on the same system without interfering with each other.

@jacksongoode
Copy link

I really hope this renaming can happen - it's weird to think that an OSS fork has "Visual Studio" prefixed to its name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] Rename VSCodium to Codium