Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repeatable dot #8979

Merged
merged 11 commits into from May 20, 2024
Merged

Fix repeatable dot #8979

merged 11 commits into from May 20, 2024

Conversation

s-kai273
Copy link
Contributor

@s-kai273 s-kai273 commented Apr 7, 2024 •
edited

What this PR does / why we need it:

  • fix repeatable dot when previous action is insert and replace one
  • test codes of repeatable dot

Which issue(s) this PR fixes
This PR fixes #8938

Special notes for your reviewer:

Repeatable dot of insert

  • example previous action: ivar
  • given text: ``(cursor is at beginning of line)
  • repeatable dot: 4.
  • result before fixing: vavavavarrrr
  • result after fixing: varvarvarvar

Repeatable dot of replace

  • example previous action: r.
  • given text: aaaaa(cursor is at beginning of line)
  • repeatable dot: 4.
  • result before fixing: .aaaa
  • result after fixing: ....a

@s-kai273 s-kai273 mentioned this pull request Apr 7, 2024
Closed
@s-kai273
Copy link
Contributor Author

I fixed the failed tests.
So hope someone to review changes please!

J-Fields
J-Fields approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@J-Fields J-Fields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-Fields J-Fields merged commit f4efb73 into VSCodeVim:master May 20, 2024
2 checks passed
@s-kai273 s-kai273 mentioned this pull request May 20, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-Fields J-Fields J-Fields approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repeatable dot of insert action results improper output
2 participants
@s-kai273 @J-Fields