Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist global marks on disk #8575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EerikSaksi
Copy link

Fixes #3841

What this PR does / why we need it:
This PR ensures that marks are persisted between sessions through a new history file. This makes marks much more usable as marks set before the editor was closed/loaded will still work. This persists local and global marks. Also includes duplicate dedection, so when old marks are overriden the history file also removes the old mark from the file.

Which issue(s) this PR fixes
#3841

Special notes for your reviewer:

@HenryTSZ
Copy link
Contributor

I merged this PR and roughly used it, and found two issues:

  1. When 'vim. showMarksInGutter' is set to true, the initialization plugin prompts: mark. position. getLineBegin is not a function
  2. Using ` + marker cannot jump and will result in an invalid button state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marks are reset/removed after some time
2 participants