fix: avoid escaping the exact word search twice

[Tal500]

Apparently, on exact word search, the word is getting regexp-escaped twice - once in

Vim/src/actions/commands/search.ts

Lines 39 to 41 in ee4888a

	if (isExact) {
	currentWord = _.escapeRegExp(currentWord);
	}

and again in

Vim/src/actions/commands/search.ts

Lines 102 to 103 in ee4888a

	const escapedNeedle = escapeRegExp(needle).replace('/', '\\/');
	const searchString = isExact ? `\\<${escapedNeedle}\\>` : escapedNeedle;

, so this PR just drop the former.

The impact for the user happens when the user configures for VSCode "what is a word". For example, my VSCode configuration on the R language is:

"[r]": {
    // This makes sure that the "." character doesn't separate symbol.
    "editor.wordSeparators": "`~!@#$%^&*()-=+[{]}\\|;:'\",<>/?",
}

It's hard to notice, but the difference is that . isn't appear there, but appear in the following. The default value for this option is:

"editor.wordSeparators": "`~!@#$%^&*()-=+[{]}\\|;:'\",.<>/?"

I do like that VSCodeVim treat my word correctly according to VSCode prefs, but I think that VSCodeVim should treat this word correctly on search (probably it was just a mistake in the code).

[J-Fields]

Could you please write a test that fails before this change and passes after?

[Tal500]

Could you please write a test that fails before this change and passes after?

Added tests

[J-Fields]

Thanks! But these tests seem to succeed before your change as well - mind adding one that tests the change? You can adjust the config for a test by passing config to newTest.

[Tal500]

Thanks! But these tests seem to succeed before your change as well - mind adding one that tests the change? You can adjust the config for a test by passing config to newTest.

I was debating how to do this so. The problem with the "config" parameter is that it doesn't allow me to change the non-vim-specific-extension configuration of VSCode. Here, what I need is to modify the global VScide config editor.wordSeparators, how to then?

[J-Fields]

Ah, right, I should really add a way to do that easily. For now just put vscode.workspace.getConfiguration(...).update(...) in setup and reverse it in teardown.