Do not revert to a single cursor when escape is pressed after a block selection #8510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously, if you created a multicursor block selection, pressed
I
, and then pressed escape, all selections except the first would be deleted. This change updates the escape behavior to preserve these selections.I've also added tests that confirm this behavior is fixed, and confirmed running the tests without the fix makes them fail.
I'll admit I don't perfectly understand the purpose of
isFakeMultiCursor
, but I'm absolutely willing to put time into changes or improvements as suggested by a reviewer.Which issue(s) this PR fixes
Fixes #8147
Fixes #7008
Special notes for your reviewer:
n/a