set selection=exclusive #8464
Open
set selection=exclusive #8464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In answer to feature request #2747
What this PR does / why we need it: Because visual selection in vim is retarded without
set selection=exclusive.Special notes for your reviewer: This PR only partially fixes the issue. It correctly alters the start of the selection as per traditional vim in
selection=exclusivemode and appears to alter the end of the selection also, but that appearance is deceptive. Can someone with more experience offer an opinion?TL;DR:
stop = stop.getLeft();change the visual appearance of the selection, but not the actual selection.postnote: this has all been implemented as
"vim.selectionExclusive": true, rather than the true vimselection=inclusive|exclusive|old. Would be happy to rectify that, if/when above issue is resolved.