Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OS and compilers in CI #1080

Closed
jcoupey opened this issue Apr 8, 2024 · 1 comment · Fixed by #1113
Closed

Update OS and compilers in CI #1080

jcoupey opened this issue Apr 8, 2024 · 1 comment · Fixed by #1113

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Apr 8, 2024

We use Ubuntu for our CI builds and the next LTS is due by the end of the month so it's a good opportunity to upgrade:

  • base image from ubuntu-22.04 to ubuntu-24.04;
  • clang to version 18;
  • gcc to version 13.

Potential blockers: 1. I have no idea when the new base will be available in GitHub actions and 2. it's fairly possible that building the upstream OSRM code will raise a handful of new problems with more recent compilers.

@jcoupey jcoupey added the CI label Apr 8, 2024
@jcoupey jcoupey added this to the v1.15.0 milestone Apr 8, 2024
This was referenced Apr 8, 2024
@jcoupey jcoupey mentioned this issue May 21, 2024
5 tasks
@jcoupey
Copy link
Collaborator Author

jcoupey commented May 22, 2024

In order to unlock some pending PR/tickets, we need to move on with this.

First clear thing is that we'll never get to cleanly build OSRM v5.27.1 (current latest version) under Ubuntu 24.04 with more recent compilers. On the other hand, building OSRM with gcc 13 and clang 15 is now OK with master as of recent fixes.

Now the purpose of our vroom + libosrm workflow is to check whether we do not break anything related to using libosrm, or conversely checking that there is no upstream break with our current workflow. Considering that this has been useful in the past, and that our own libosrm integration code does not change much anyway, I think it makes sense that we upgrade OSRM to a latest version, even if it means pinning to a specific master commit until there is a new upstream release. I've started toying with this in #1113.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant