Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warning in gcc-12 build #1092

Closed
kkarbowiak opened this issue Apr 17, 2024 · 5 comments
Closed

Compiler warning in gcc-12 build #1092

kkarbowiak opened this issue Apr 17, 2024 · 5 comments

Comments

@kkarbowiak
Copy link
Contributor

Since switch to gcc-12 there are some warnings emmited, e.g.
https://github.com/VROOM-Project/vroom/actions/runs/8720162756/job/23921121862#step:4:106

Those seem to be false-positives caused by a bug in gcc. I have seen very similar ones in other projects (e.g. -Wstringop-overflow due to gcc bug 106757).

A simple workaround is to disable the specific warning in place it occurs.

@jcoupey
Copy link
Collaborator

jcoupey commented Apr 25, 2024

Hum, if this is a bug, maybe it would simply just vanish when updating to gcc 13 as part of #1080?

@kkarbowiak
Copy link
Contributor Author

kkarbowiak commented Apr 29, 2024

Hum, if this is a bug, maybe it would simply just vanish when updating to gcc 13 as part of #1080?

Quite possibly. Compiling using g++ 13.2.1 does not show this warning. I am not sure which version will be shipped with the new Ubuntu though.

Edit: looks like Ubuntu 24.04 is out and features gcc 14.

@jcoupey
Copy link
Collaborator

jcoupey commented Apr 29, 2024

looks like Ubuntu 24.04 is out

It is available for fresh installs but the update path from the previous LTS is not open yet, which is currently the blocker for the compilation tests I plan to run locally.

and features gcc 14.

That is both good in term of having a recent compiler, but bad in the sense that we'll probably be in even bigger trouble to get OSRM to compile...

@kkarbowiak
Copy link
Contributor Author

I have installed 24.04 as a virtual machine. It ships with g++ 13.2.0 and clang++ 18.1.3. Looking at the toolchain upgrades part of the release notes page I thought it would be g++ 14.

For what it's worth, both compilers emit no warning when compiling vroom.

@jcoupey
Copy link
Collaborator

jcoupey commented May 22, 2024

Closing as we don't need to work around this problem any more since we now use gcc 13 and 14 in CI builds.

@jcoupey jcoupey closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants