Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rt: Keep ASCII Codes (included extended) i.e. 32-126 & 128-255 #108

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

roman536
Copy link

@roman536 roman536 commented Aug 8, 2018

Non-ascii characters should not specify extended codes i.e. 128-255.
We need them to write on UTF-8 file (e.g. German umlauts ÄäÖöÜüß)

@billyswong
Copy link

I incorporated my own change that keep even the non-ascii i.e. those >255 also unescaped.

@SoccerDitter
Copy link

I have written down here how it worked for me. so that the German letters such as Ü and ß are displayed.
@roman536

https://github.com/VBA-tools/VBA-JSON/pull/168#issuecomment-1647675192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants