Add hipstdpar support to BabelStream #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdeakin
requested changes
May 13, 2024
| @@ -50,4 +66,13 @@ macro(setup) | |||
| register_definitions(USE_ONEDPL) | |||
| register_link_library(oneDPL) | |||
| endif () | |||
| if (CLANG_OFFLOAD) | |||
There was a problem hiding this comment.
I'm not totally sold on the name of this definition as CLANG is not specific to AMD, but the CLANG_FLAGS set below are definitely specific. Can we rename this please to something appropriate?
There was a problem hiding this comment.
Would replacing CLANG_OFFLOAD with AMDGPU_TARGET_OFFLOAD and CLANG_FLAGS with AMDGPU_TARGET_OFFLOAD_FLAGS be acceptable?
|
It's great to see hipstdpar working, so let's work to get this merged in. Thanks for the contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for offload to AMD GPUs using the
par_unseqexecution policy in C++ standard parallelism algorithms. To trigger the GPU offload of all parallel algorithms, the--hipstdparcompilation flag must be provided. For GPU targets other than the current default ofgfx906, the--offload-arch=<arch_string>option must also be provided at compile time.When using ROCm 6.1.0, the compilation commands may look like the following if compiling for an AMD Instinct MI200 series GPU:
Remember to set the environment variable to enable address translation and page migration (where applicable) when running
std-data-streamorstd-indices-stream: