rocket: avoid doing 2 or 3 Cvar::Get() trap calls per OnUpdate() call per cvar element #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DolceTriade
reviewed
May 11, 2024
DolceTriade
approved these changes
May 11, 2024
illwieckz
force-pushed
the
illwieckz/rml-cvar-onupdate
branch
3 times, most recently
from
5b080d8
to
90629bf
Compare
DolceTriade
approved these changes
May 11, 2024
illwieckz
force-pushed
the
illwieckz/rml-cvar-onupdate
branch
from
90629bf
to
b61d62b
Compare
|
There were only extra calls it the cvar value or attributes changed, right? It wouldn't make much a performance difference in the average case. |
illwieckz
force-pushed
the
illwieckz/rml-cvar-onupdate
branch
from
b61d62b
to
112b964
Compare
illwieckz
changed the title
… per cvar element
illwieckz
force-pushed
the
illwieckz/rml-cvar-onupdate
branch
from
112b964
to
fa50c36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid doing 2 or 3
Cvar::Get()trap calls perOnUpdate()call percvarelement per frame.🤦♀️️🤦♀️️🤦♀️️