Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appveyor: Delete custom python code #2992

Merged
merged 1 commit into from May 12, 2024
Merged

appveyor: Delete custom python code #2992

merged 1 commit into from May 12, 2024

Conversation

DolceTriade
Copy link
Member

@DolceTriade DolceTriade commented May 11, 2024

Rely on the default python. It is probably the current python release,
which is sufficient to build unv.

Fixed: https://ci.appveyor.com/project/DolceTriade/unvanquished/builds/49793431

The old python code relied on python2 which was failing to download jinja2, likely due to deprecated TLS.

@DolceTriade DolceTriade marked this pull request as ready for review May 11, 2024 05:52
@DolceTriade DolceTriade reopened this May 11, 2024
Rely on the default python. It is probably the current python release,
which is sufficient to build unv.
@DolceTriade DolceTriade changed the title cbse: Bump jinja2 version to fix appveyor appveyor: Delete custom python code May 11, 2024
Copy link
Member

@illwieckz illwieckz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slipher
Copy link
Contributor

slipher commented May 11, 2024

Fixed: https://ci.appveyor.com/project/DolceTriade/unvanquished/builds/49793431

"Build success" it says. What was fixed?

@DolceTriade
Copy link
Member Author

"Build success" it says. What was fixed?

Updated the PR message. Basically we were using python2 before and that was failing to fetch any pip deps probably due to outdated TLS.

@DolceTriade DolceTriade merged commit 063896b into master May 12, 2024
2 checks passed
@DolceTriade DolceTriade deleted the ishq/appv branch May 12, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants