cgame: introduce cg_lowModels to load low quality models #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example, default models:
Low models I modified:
|
We can probably generate them from the original models. |
|
The effort of doing low poly models is probably not worth it anyway, the gain would not be worth the effort. |
|
I agree. |
illwieckz
force-pushed
the
illwieckz/low-models
branch
4 times, most recently
from
cabe219
to
c7457d5
Compare
illwieckz
force-pushed
the
illwieckz/low-models
branch
from
c7457d5
to
cc4197d
Compare
slipher
reviewed
May 8, 2024
| @@ -526,21 +526,21 @@ static bool CG_ParseBuildableSoundFile( const char *filename, buildable_t builda | |||
| return true; | |||
| } | |||
|
|
|||
| static bool CG_RegisterBuildableAnimation( buildableInfo_t *ci, const char *modelName, int anim, const char *animName, | |||
| static bool CG_RegisterBuildableAnimation( buildableInfo_t *ci, const char *modelName, const char* foundSuffix, int anim, const char *animName, | |||
There was a problem hiding this comment.
How about a single argument with the contents of fileBase from the other function, instead of modelName+foundSuffix?
slipher
reviewed
May 8, 2024
| @@ -182,6 +182,8 @@ Cvar::Cvar<std::string> cg_sayCommand("cg_sayCommand", "instead of talking, chat | |||
| // TODO: only works for player models. Buildings and weapons are also relevant | |||
| Cvar::Cvar<bool> cg_lazyLoadModels("cg_lazyLoadModels", "load models only when needed", Cvar::CHEAT, false); | |||
|
|
|||
| Cvar::Cvar<bool> cg_lowModels("cg_lowModels", "load low quality models when available", Cvar::NONE, false); | |||
|
How are you generating these models? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
cg_lowModelsto load low quality models.The purpose of this cvar is to be used in
lowandlowestpresets.If
cg_lowModelsis enabled, when looking forbuildables/eggpod/eggpod.iqm, loadbuildables/eggpod/eggpod_low.iqmif it exists.It is only implemented for buildables for now, I may implement it for player models later.
The purpose is to load a low quality variant of a model for performance purpose.
This may be a low poly model, but I doubt we have the resource to produce some.
What we can do though, is to edit existing IQM models with IQE Browser and delete some bones.
Some low-end old graphics card can only hardware accelerate the model animations if the models have no more than 41 bones.
Some of our models have many more than that, sometime more than an hundreds of that, forcing the game to fallback on a slow CPU implementation.
But many of our models have some bones we can remove, like legs of buildables. Those legs are animated for moving when being hurt or things like that, but removing the leg animation bones and a few others like the head bones do not break the whole animation most of the time.
It looks like
Cvar::Latchis not implemented yet on CGame side, this would be appreciated as thecg_lowModelscvar should be latched (we need to reload the models to see a difference).This commit should works on
masterbut I make this PR targetfor-0.55.0/syncbecause since it requires models that are not released, no one can use the cvar yet anyway, and targetting thefor-0.55.0/syncmakes things easier to me when dealing with the various repositories.