Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cg_marks: implement trap_CM_BatchMarkFragments to process all impact marks in one call #2981

Merged
merged 1 commit into from May 12, 2024
Merged

cg_marks: implement trap_CM_BatchMarkFragments to process all impact marks in one call #2981

merged 1 commit into from May 12, 2024

Conversation

illwieckz
Copy link
Member

@illwieckz illwieckz commented May 4, 2024 •
edited

@illwieckz illwieckz marked this pull request as draft May 4, 2024 08:38
@illwieckz
Copy link
Member Author

The purpose is to only do a single trap call for all marks on the screen at once. This is expected to bring significant performance boost while many players are fighting around, and especially in alien base as alien buildable creep registers an impact mark every frame. Maybe dead bodies do the same too.

@illwieckz
Copy link
Member Author

illwieckz commented May 4, 2024 •
edited

Unfortunately it doesn't work, marks are not displayed, so I did a mistake somewhere, and I'm looking for help to debug it.

@illwieckz illwieckz changed the base branch from master to for-0.55.0/sync May 4, 2024 08:41
@illwieckz illwieckz force-pushed the illwieckz/impactmark-array/sync branch 5 times, most recently from 2efb6c1 to 326af72 Compare May 4, 2024 09:11
@illwieckz
Copy link
Member Author

My re.MarkFragments in engine always return 0…

@illwieckz illwieckz force-pushed the illwieckz/impactmark-array/sync branch 3 times, most recently from 15a7d2f to 88bc05b Compare May 5, 2024 03:16
@illwieckz
Copy link
Member Author

I don't get it. I entirely rewrote this branch from scratch, step by step, checking that everything was working on every step.
But as soon as I call trap_CM_MarkFragmentsArray, it stops to work.

Even if I copy-paste the original code into trap_CM_MarkFragmentsArray, even if I make trap_CM_MarkFragmentsArray calling trap_CM_MarkFragments.

@illwieckz illwieckz force-pushed the illwieckz/impactmark-array/sync branch 2 times, most recently from 2e1059a to 31be9a2 Compare May 5, 2024 03:56
@illwieckz illwieckz changed the title WIP: process all impact marks at once Process all impact marks at once May 5, 2024
@illwieckz
Copy link
Member Author

The PR is ready, commits will be squashed, no need to review them one by one.

@illwieckz illwieckz marked this pull request as ready for review May 5, 2024 06:32
@illwieckz illwieckz mentioned this pull request May 5, 2024
Merged
@illwieckz illwieckz force-pushed the illwieckz/impactmark-array/sync branch from 6931964 to a10e7ca Compare May 6, 2024 00:36
@illwieckz illwieckz changed the title Process all impact marks at once Process all impact marks in one call May 6, 2024
@illwieckz illwieckz changed the title Process all impact marks in one call cg_marks: implment trap_CM_MarkFragmentsArray to process all impact marks in one call May 6, 2024
@illwieckz illwieckz changed the title cg_marks: implment trap_CM_MarkFragmentsArray to process all impact marks in one call cg_marks: implement trap_CM_MarkFragmentsArray to process all impact marks in one call May 6, 2024
@illwieckz illwieckz changed the title cg_marks: implement trap_CM_MarkFragmentsArray to process all impact marks in one call cg_marks: implement trap_CM_BatchMarkFragments to process all impact marks in one call May 6, 2024
@illwieckz illwieckz mentioned this pull request May 6, 2024
Open
@illwieckz illwieckz force-pushed the illwieckz/impactmark-array/sync branch 2 times, most recently from 74ca922 to abe0d2e Compare May 10, 2024 06:49
@illwieckz illwieckz force-pushed the illwieckz/impactmark-array/sync branch 5 times, most recently from d51fa44 to beda1f8 Compare May 10, 2024 07:43
@illwieckz illwieckz added T-Improvement Improvement for an existing feature T-Performance labels May 10, 2024
@illwieckz illwieckz force-pushed the illwieckz/impactmark-array/sync branch from beda1f8 to 1be52df Compare May 10, 2024 15:49
@illwieckz @slipher
cg_marks: implement trap_CM_BatchMarkFragments to process all impact …
4a0b1d4 
…marks in one call

Co-authored-by: slipher <slipher@protonmail.com>
@illwieckz illwieckz force-pushed the illwieckz/impactmark-array/sync branch from 1be52df to 4a0b1d4 Compare May 10, 2024 18:00
@slipher
Copy link
Contributor

slipher commented May 11, 2024

LGTM

@illwieckz illwieckz merged commit 9e5acd7 into for-0.55.0/sync May 12, 2024
5 of 6 checks passed
@illwieckz illwieckz deleted the illwieckz/impactmark-array/sync branch May 12, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
T-Improvement Improvement for an existing feature T-Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@illwieckz @slipher