Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgame: load IQM human model #2975

Open
wants to merge 2 commits into
base: for-0.55.0/sync
Choose a base branch
from
Open

Conversation

illwieckz
Copy link
Member

@slipher
Copy link
Contributor

slipher commented Apr 17, 2024

This should go into a for-x.y.z branch so that developers can keep working on master without having to acquire new assets.

Is there supposed to be any user-visible change from this?

@illwieckz
Copy link
Member Author

illwieckz commented Apr 18, 2024

This should go into a for-x.y.z branch

Yes, I'll change the target later. I wanted to push the branch early so @DolceTriade can put his hands on it and have everything wired up to test any new animation he may implement for the psaw or other weapons (flamer…).

Is there supposed to be any user-visible change from this?

No. Any visible change should be considered a bug before being investigated.

The purpose of those branch is only to convert the file formats and file layout to the asset pipeline we currently have the best support for.

One can also see the benefit of using recommended conventions so we can rely on default loaders, meaning we can drop the custom loading implementation.

Migrating the file for the sake of conventions is something I wanted to do for years but the purity win was not worth the effort. Now that @DolceTriade is working on models, making the files compatible with a better workflow and a working production pipeline is worth the effort.

@illwieckz illwieckz changed the base branch from master to for-0.55.0/sync May 8, 2024 06:25
@DolceTriade
Copy link
Member

Lgtm but this should be the last thing we merge since it requires different assets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants