Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui,presets: switch to r_lightMode #2894

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

illwieckz
Copy link
Member

The graphics menu now list light mapping and vertex lighting and makes use of the r_lightMode cvar.

The lowest graphics preset now uses vertex lighting.

See:

The graphics menu now list light mapping and vertex lighting
and makes use of the r_lightMode cvar.

The lowest graphics preset now uses vertex lighting.
@illwieckz illwieckz added A-UI T-Improvement Improvement for an existing feature labels Jan 8, 2024
@illwieckz
Copy link
Member Author

Related engine PR has been merged:

It means that without this patch the Light option in UI is currently doing nothing.

@slipher
Copy link
Contributor

slipher commented Jan 12, 2024

I guess the old one shouldn't be deleted from the presets until 0.55 is released?

@illwieckz
Copy link
Member Author

I guess the old one shouldn't be deleted from the presets until 0.55 is released?

There was no vertex lighting implemented before, and all presets were enabling light mapping.

Setting r_lightMode on 0.54.1 will do nothing.

But the best is probably to wait for the release to merge this (if we do a 0.54.2 for portal and lightmap fixes), or merge to for-0.55.0/sync. In all cases the Lights menu will be broken on 0.54.1 once this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI T-Improvement Improvement for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants