cgame: preselect a map in server creation window, remember it #2883
Conversation
illwieckz
force-pushed
the
illwieckz/preselect-map
branch
from
f88a7f1
to
5bf062a
Compare
…ation window Also unify the look of the callvote map window with the server_create one.
illwieckz
force-pushed
the
illwieckz/preselect-map
branch
2 times, most recently
from
0a5c009
to
c4d4050
Compare
|
I added a commit that forces the height of the levelshot. I forced This prevents the server creation window size to change dynamically while scrolling maps, hence preventing the “Start” button to move up and down while scrolling map, and it would prevent a nasty map with a nasty |
illwieckz
force-pushed
the
illwieckz/preselect-map
branch
2 times, most recently
from
c6f01c9
to
b0f7606
Compare
|
I don't have time to review or test, but I would ask to ensure that this does not cause a map pak to be loaded before opening the map menu. |
This shouldn't do that |
| @@ -34,6 +34,8 @@ Maryland 20850 USA. | |||
|
|
|||
| #include "cg_local.h" | |||
|
|
|||
| static Cvar::Cvar<std::string> g_defaultMap("g_defaultMap", "default map to play", Cvar::ARCHIVE, "plat23"); | |||
| { | ||
| if ( rocketInfo.data.mapList.size() != 0 ) | ||
| { | ||
| CG_Rocket_BuildMapList( nullptr ); |
There was a problem hiding this comment.
Build the list only if it is already nonempty? Seems weird. Probably this shouldn't be here at all?
There was a problem hiding this comment.
Ah no it should be == 0, well, I copypasted CG_Rocket_GetResolutionListIndex the cargo cult way, so I don't know if that code is needed, but when duplicating, that should be ==. I'll fix that.
There was a problem hiding this comment.
Since the code worked even with !=0 this shouldn't be needed at all.
Preselect a map in server creation window, this means a newcomer has less actions to do to create a server when trying the game for the first time, and then remember the last started map.