Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up partition params #2979

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

chore: clean up partition params #2979

wants to merge 3 commits into from

Conversation

Coniferish
Copy link
Collaborator

Best to review commit by commit.

This PR is the first for cleaning up the partition params. Fixes in this PR:

  • Move non-partitioner modules to unstructured/partition/utils/
    • Note that json.py was not moved, but it could be if deemed appropriate.
  • Remove chunking_strategy param from all partitioners since it is accessed through **kwargs in all partitioners
  • Add * to partitioner params.

@cragwolfe
Copy link
Contributor

Is there something that needs to be fixed by this PR?
What would it enable in the future if it is not fixing anything?

As it stands, imo this harms the readability of the code base.
1/ the * pattern is just weird
2/ a reader of the source code of a partition_ function is less clued into the fact there is this critical chunking_strategy param available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants