-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle playlist of internet radio stations #4572
base: main
Are you sure you want to change the base?
Conversation
…sts_lc_name Do not lowercase playlist name for display.
log resource finding
fix ServerSentEvents implementation
fix HttpExchangeServletRequest Servlet implementation
implements v12 jetty.server implements v12 jetty.client
# Conflicts: # pom.xml # react-client/package.json # react-client/yarn.lock
# Conflicts: # CHANGELOG.md # src/main/external-resources/logback.headless.xml # src/main/external-resources/logback.xml
more log
V14 fix directory not found on scanner
fix NPE when UPnP device strangely do not have details (JUPnP).
# Conflicts: # pom.xml # react-client/package.json # react-client/yarn.lock
# Conflicts: # pom.xml # react-client/package.json # react-client/yarn.lock
# Conflicts: # pom.xml # react-client/package.json # react-client/yarn.lock
# Conflicts: # CHANGELOG.md
# Conflicts: # pom.xml # react-client/package.json # react-client/src/App.tsx # react-client/yarn.lock
# Conflicts: # CHANGELOG.md
clean up mess
clean up mess
execute throws SQLException don't catch it
…ServerHandler.java javahttpserver was removed
exclude
remove non used var
I'm not reviewed the core goal of the PR. Only the Java part and UMS integration. |
stop using 'code entered is invalid' to bypass normal code.
Tell me if I'm wrong, but I checked the code and I think that the changes in For the other part (retrieving media/radio info), we should care that some users do not want that UMS browse the internet (that is why I put this in external). |
If you want the playlists to work as intended, UMS needs to retrieve the data from the external radio station and stream it to the renderer (is kind of a proxy). The stream could also be transcoded if needed. The external URL could of course on top be presented as a
But: If UMS is not connecting to the internet, it can not serve the radio station. Then this feature won't work. |
Added playlist support for handling internet radio stations. No transcoding yet (probably not neccesary for the usual codecs).
Feature can be tested with:
my_internet_radio_station.m3u file consists of radio stations like
VLC media player -> Universal Plug 'n Play -> UMS -> my_internet_radio_station.m3u -> radio
Netty 3 MediaServer implementation seems to have an issue serving large chunked streams and becomes more and more unresponsive over some time (a few seconds !).
JDK MediaServer implementation is much more responsive and stable over time.
server_engine
config entry should therefore be something like 1.Todo :
[x] cache radio station metadata in a table
[-] currently for for a radio station 2 resources are created, one is VLC Web Audio (probably the renderer) and one is "no transcoding". Maybe this is only cosmetic and can stay this way.
[x] read metadata from radio browser API if possible
[-] adding support for hardware audio player (not in scope any more)