Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIRO-1796 Change API used to set and query maximum, velocity of a joint. #190

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

vidurvij-Unity
Copy link
Contributor

@vidurvij-Unity vidurvij-Unity commented Mar 3, 2022

Proposed change(s)

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

#189

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions, ROS packages, and Unity project files as appropriate so we can reproduce the test environment.

Test Configuration:

  • Unity Version: [e.g. Unity 2020.2.0f1]
  • Unity machine OS + version: [e.g. Windows 10]
  • ROS machine OS + version: [e.g. Ubuntu 18.04, ROS Noetic]
  • ROS–Unity communication: [e.g. Docker]

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works
  • Increased the test coverage criteria by 3%
  • Updated the Changelog and described changes in the Unreleased section
  • Updated the documentation as appropriate

Other comments

@vidurvij-Unity
Copy link
Contributor Author

@K-Tone One of the test is failing. It is down to the fact that I am not able to set this during editorMode. Is this intended or a bug ?

@vidurvij-Unity vidurvij-Unity changed the title Change API used to set and query maximum, velocity of a joint. AIRO-1796 Change API used to set and query maximum, velocity of a joint. Mar 10, 2022
@unity-cla-assistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants