Update SlicingCrash.yaml #18977
Open
Update SlicingCrash.yaml #18977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saumyaj3
approved these changes
Apr 30, 2024
saumyaj3
requested changes
Apr 30, 2024
| @@ -35,7 +35,7 @@ body: | |||
| - type: markdown | |||
| attributes: | |||
| value: | | |||
| We work hard on improving our slicing crashes. Our most recent release is 5.6.0. | |||
| We work hard on improving our slicing crashes. Our most recent release is 5.7.1. | |||
There was a problem hiding this comment.
this is inside placeholder for 5.6.0
There was a problem hiding this comment.
It's the text under where the user submits the version
There was a problem hiding this comment.
I mean we should also change the placeholder on line 32
There was a problem hiding this comment.
IMPO
Since the majority of crashes are from before 5.7 then I would suggest keeping it as is.
Users would need to type the value either way so it's not removing/adding a step I would say.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: