Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stability for motors PI, Zaber #660

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

timoML
Copy link
Contributor

@timoML timoML commented Jun 1, 2021

Improve the stability of the serial connection for motor_stage_pi and zaber_motor_rotation_stage.

Motivation and Context

On setup 3 and after adding a few new serial devices, scanning the magnetic field with above stages was painfull and plagued by a lot of hangs and crashes.
The main change of this PR is to reduce the number of serial command issued by stacking together calls to the serial hardware where possible.

How Has This Been Tested?

On setup3 magnet alignment runs way smoother now.
In particular, the magnet gui wouldn't hang while scanning without any warning/error issued.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in the changelog (documentation/changelog.md)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/updated for the module the config example in the docstring of the class accordingly.
  • I have checked that the change does not contain obvious errors (syntax, indentation, mutable default values).
  • I have tested my changes using 'Load all modules' on the default dummy configuration with my changes included.
  • All changed Jupyter notebooks have been stripped of their output cells.

- in serial com: replace waiting for timeout by fixed number of chunks to read
- add timeout if waiting is necessary
- fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant