Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ni analog output #640

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alrik-durand
Copy link
Contributor

Description

I've added a hardware module to interface a NI9263 4 channel analog output. Hardware is interfaced via the ProcessControlInterface interface.

Motivation and Context

Many experiment uses NI 6323 card with multiple functionalities. Analog output is one of them the card only have 4 analog output. The NI9263 can be used via USB or ethernet (depending of the module used for connection) and add more analog output.
Theses analog output are interfaced via the ProcessControlInterface.

How Has This Been Tested?

Tested with a NI9263 connected via USB cDAQ-9171 to a windows 10 computer.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in the changelog (documentation/changelog.md)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/updated for the module the config example in the docstring of the class accordingly.
  • I have checked that the change does not contain obvious errors (syntax, indentation, mutable default values).
  • I have tested my changes using 'Load all modules' on the default dummy configuration with my changes included.
  • All changed Jupyter notebooks have been stripped of their output cells.

Copy link
Contributor

@meiwud334 meiwud334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have the hardware here in Ulm, basing only on the code no problem were spotted.

Copy link

@QTslav QTslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to set the analog output voltage to zero when deactivating the module?
I could see some usecases where it would be preferential to keep the voltage applied.

@Neverhorst
Copy link
Member

We don't have the hardware here in Ulm, basing only on the code no problem were spotted.

Well, of course we have the hardware. You can basically take any of the *insert arbitrary large number* NI cards in our labs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants