Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryomagnetics vector magnet power supply hardware #636

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

alrik-durand
Copy link
Contributor

Description

This PR adds a hardware module to interface Cryomagnetics vector magnet power supply. No interface is used but hardware can be operated via notebooks.

Motivation and Context

This PR adds support for Cryomagnetics vector magnet power supply.
It does not use the MagnetInterface as it is an old interface very hardware specific which is not well suited for this hardware. Developing a proper interface, logic and GUI for a superconducting magnet should be done at a later stage.
This PR is enough to interact via script for the moment.

How Has This Been Tested?

This has been tested with the hardware via ethernet via a notebook.

Screenshots (only if appropriate, delete if not):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in the changelog (documentation/changelog.md)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/updated for the module the config example in the docstring of the class accordingly.
  • I have checked that the change does not contain obvious errors (syntax, indentation, mutable default values).
  • I have tested my changes using 'Load all modules' on the default dummy configuration with my changes included.
  • All changed Jupyter notebooks have been stripped of their output cells.

@Neverhorst Neverhorst added this to In progress in Magnetstuff via automation Jan 26, 2021
@alrik-durand
Copy link
Contributor Author

I just updated the code with a new version.
This update was required because setting a setpoint in Gauss create problem because the hardware is rounding the value to the nearest gauss integer (why I don't know...).
This update uses the current as setpoint to circumvent the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Magnetstuff
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants