Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New trigger interface #629

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

New trigger interface #629

wants to merge 10 commits into from

Conversation

kay-jahnke
Copy link
Member

New tool chain for sending simple digital triggers. These triggers are software timed and therefore are not recommended for time sensitive triggering.

Description

An interface was written including a dummy hardware. Also a logic and gui module were created for demonstration.
As the most common use case of triggers is automation, the triggers will probably most often be fired from a notebook and not by the gui.

Motivation and Context

Sometimes an external controller needs to be reset or a state change needs to be triggered.

How Has This Been Tested?

tested with dummy on Linux 5.9.1-1-MANJARO

Screenshots:

very simple GUI with push buttons:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in the changelog (documentation/changelog.md)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/updated for the module the config example in the docstring of the class accordingly.
  • I have checked that the change does not contain obvious errors (syntax, indentation, mutable default values).
  • I have tested my changes using 'Load all modules' on the default dummy configuration with my changes included.
  • All changed Jupyter notebooks have been stripped of their output cells.

@GRexBayer
Copy link

When starting the dummy version on Windows 10, Windows has problems with the geometry of the application window.
Loading the trigger module results in:

QWindowsWindow::setGeometry: Unable to set geometry 105x86+907+483 on QWidgetWindow/'MainWindowWindow'. Resulting geometry: 120x86+907+483 (frame: 8, 31, 8, 8, custom margin: 0, 0, 0, 0, minimum size: 50x86, maximum size: 16777215x16777215).
QWindowsWindow::setGeometry: Unable to set geometry 105x117+907+483 on QWidgetWindow/'MainWindowWindow'. Resulting geometry: 120x117+907+483 (frame: 8, 31, 8, 8, custom margin: 0, 0, 0, 0, minimum size: 50x117, maximum size: 16777215x16777215).
QWindowsWindow::setGeometry: Unable to set geometry 105x148+907+483 on QWidgetWindow/'MainWindowWindow'. Resulting geometry: 120x148+907+483 (frame: 8, 31, 8, 8, custom margin: 0, 0, 0, 0, minimum size: 56x148, maximum size: 16777215x16777215).
QWindowsWindow::setGeometry: Unable to set geometry 105x179+907+483 on QWidgetWindow/'MainWindowWindow'. Resulting geometry: 120x179+907+483 (frame: 8, 31, 8, 8, custom margin: 0, 0, 0, 0, minimum size: 56x179, maximum size: 16777215x16777215).

@GRexBayer
Copy link

Besides the Geometry problem by Windows 10, the dummy version seems to run without problems.
Pressed all the buttons and they act as expected. OS info: OS Name Microsoft Windows 10 Pro
Version 10.0.19041 Build 19041

@kay-jahnke
Copy link
Member Author

@GRexBayer fixed the warnings by reworking the gui. Please test again.

@GRexBayer
Copy link

Found no warnings, the window is displayed with an appropriate size!
Checked hopefully thoroughly enough. Pressed all buttons, deactivated the module and restarted QuDi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants