IVI interfaces #466
Open
IVI interfaces #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interface functionality and the ivi implementation in the filename. Change also the class name.
…terface.py) into the ivi implementation files.
…face naming scheme
…e class dictionary this solves the issue with QT signals being added dynamically after class instanciation.
… follow the same structure as scope interface
…ith .NET specification
Neverhorst
requested changes
Mar 29, 2019
There was a problem hiding this comment.
Ok, so far I have not tested functionality with real hardware.
- Could you please put all IVI related modules into a single subfolder, like
hardware/ivi/? - For such a big, new (in terms of qudi) hardware module concept the documentation is way too shallow in my opinion. There is a lot more documentation needed on how to implement new ivi modules and what the crucial points are for a scientist sitting in the lab and implementing a module for a new device.
Also the existing doc is a bit thin on what these namespaces are etc.
core/manager.py
Outdated
| @@ -683,7 +683,7 @@ def connectModule(self, base, mkey): | |||
| 'legacy format since it contains a dot.' | |||
| ''.format(base, mkey, c)) | |||
| logger.error('{0}.{1}.{2}: Connector is no dictionary.' | |||
| ''.format(c, base, mkey)) | |||
| ''.format(c, base, mkey)) | |||
There was a problem hiding this comment.
Could you please remove that? This is neither one tab from the "logger" statement nor directly below the start of the string literal.
added 6 commits
May 25, 2019 17:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interfaces for oscilloscopes and AWGs following the IVI specifications. Wrapper for python ivi instrument library.
Description
The IVI foundation has published industry specifications for interfaces to various instruments. Here I define interfaces which follow these specifications and implement a wrapper to the python ivi instrument library. So far interfaces for oscilloscopes and AWGs are implemented.
This pull request is based on an earlier pull request which was reviewed by @a-stark. Since then I have improved the interface a lot. It is much more streamlined now and in my opinion easier to implement.
Motivation and Context
Qudi needs a standard interface for common instruments and the IVI specifications deliver such an interface definition.
How Has This Been Tested?
Using a Tektronix AWG5002C and a Keysight DSOS204A.
Screenshots (only if appropriate, delete if not):
Types of changes
New interfaces and a wrapper.
Checklist:
documentation/changelog.md)