fix: remove the requirement for defining GOOGLE_APPLICATION_CREDENTIALS #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GOOGLE_APPLICATION_CREDENTIALS` or `credential.json` is not a requirement for using Speech Recognition. `GOOGLE_APPLICATION_CREDENTIAL` is the least preferred way of authenticating with a google service. When running on Google Cloud, they inherently have the credentials attached to the infrastructure (using IAM roles), so, `GOOGLE_APPLICATION_CREDENTIALS` is not a hard requirement. At any case, if any environment variable is not defined, or `credentials.json` is not provided or detected by google cloud package, the package will produce an exception. By leaving the authentication part to `google.cloud` package, we can remove the redundant checks from Speech Recognition's code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOOGLE_APPLICATION_CREDENTIALSorcredential.jsonis not a requirement for using Speech Recognition.GOOGLE_APPLICATION_CREDENTIALis the least preferred way of authenticating with a google service. When running on Google Cloud, they inherently have the credentials attached to the infrastructure (using IAM roles), so,GOOGLE_APPLICATION_CREDENTIALSis not a hard requirement. At any case, if any environment variable is not defined, orcredentials.jsonis not provided or detected by google cloud package, the package will produce an exception. By leaving the authentication part togoogle.cloudpackage, we can remove the redundant checks from Speech Recognition's code.