Bootcamp: Annika Logarta #122
Conversation
| htim1.Instance = TIM1; | ||
| htim1.Init.Prescaler = 14; | ||
| htim1.Init.CounterMode = TIM_COUNTERMODE_UP; | ||
| htim1.Init.Period = 64000; |
Core/Src/main.c
Outdated
| uint16_t ADC_Value; | ||
| float PWM_DutyCycle; // | ||
| uint8_t PWM_DutyCycle_Count; | ||
| const uint16_t PERIOD = 0xfa00; // 64000, our period, in hexadecimal |
There was a problem hiding this comment.
Honestly, I think it makes more sense to use decimal here. Sometimes I ask people to use hex to represent the data because those data are highly associated with bytes, using hexadecimal can increase the readability of the text. Here, I don't think using hex is offering any readability advantage comparing to others...
| float PWM_DutyCycle; // | ||
| uint8_t PWM_DutyCycle_Count; | ||
| const uint16_t PERIOD = 0xfa00; // 64000, our period, in hexadecimal | ||
|
|
||
| /* USER CODE END 2 */ |
There was a problem hiding this comment.
You are missing a hal function call here that can ask the microcontroller to start the PWM wave as you configured in the ioc file. Unfortunately, if you don't call that function, no wave will be produced from that pin. I recommend searching about stm32 pwm and I will see the function I am talking about.
Core/Src/main.c
Outdated
| /* USER CODE END 2 */ | ||
|
|
||
| /* Infinite loop */ | ||
| /* USER CODE BEGIN WHILE */ | ||
| while (1) | ||
| { | ||
| HAL_GPIO_WritePin(GPIOB, GPIO_PIN_6, GPIO_PIN_RESET); // Pulling CS line high |
|
|
||
| // Below is combining the necessary 10 bits of data we need into 1. | ||
| ADC_Value = RxData[1] << 8; | ||
| ADC_Value |= RxData[2]; |
There was a problem hiding this comment.
The bit-wise manipulations here are correct. But according to the datasheet, unexpected bits can occupy the first 6 bits in the RxData[1]', so I would recommend masking the ADC_Value` with a 10-bit mask to make sure only 10-bits are used from the rx_data.
| // Convert to a counter | ||
| // ADC Value 0 means PWM is 5%, ADC value 1023 means PWM is 10% | ||
| PWM_DutyCycle = ADC_Value/(0x3ff); | ||
| PWM_DutyCycle_Count = (PERIOD*0.05*(1+PWM_DutyCycle)); |
No description provided.