-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MS5611 Driver Update #52
Open
FolaFatola
wants to merge
15
commits into
main
Choose a base branch
from
feature/driver/altimeter
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce with spi handler and cs/ps port and pins
…1 class, and more descriptive naming for MS5611 calibration coefficients
…iption formatting on calculateTempPres() function
…led in getPressure() and getTempemrautre() functions
…n the constructor
… elevation in constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What manual tests were used to validate the code?
Temperature, pressure and altitude values were printed to the UART. For the altitude, the barometer was raised a few meters and measurements were observed. For temperature, values were compared to local thermometer. The pressure was compared to the pressure of the city I was in (googled).
Testing for failures:
The measurements in this driver return a bool - true if no communication errors occur and false if they do occur
If HAL_SPI_TransmitReceive_IT doesn't HAL_OK, communication_success_ is assigned the value false. To test if that would cause if that would cause the get functions to return false (getPressure, getTemperature, etc), I would assign communication_success_ false and check the results.
Forced failure example #1:
Forced failure example #2:
Results:
Test loop:
What unit tests were used to validate the code?