Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: APPS-2665 When user clicks the x on search keyword, the search is not triggered automatically #509

Merged
merged 1 commit into from
May 16, 2024
Merged

fix: APPS-2665 When user clicks the x on search keyword, the search is not triggered automatically #509

merged 1 commit into from
May 16, 2024

Conversation

farosFreed
Copy link

@farosFreed farosFreed commented May 15, 2024 •
edited by jira bot

Connected to APPS-2665

Notes:

Needed to add additional syntax to get the child component to emit the 'clear' event to its parent

Checklist:

  • [X ] I checked that it is working locally in the dev server
  • [ X] I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
  • I added a screenshot of it working
  • UX has reviewed and approved this
  • I assigned this PR to someone on the dev team to review
  • [X ] I used a conventional commit message
  • [X ] I assigned myself to this PR

@farosFreed farosFreed added the bugfix Something isn't working label May 15, 2024
@farosFreed farosFreed self-assigned this May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://deploy-preview-509--ucla-library-storybook-vue3x.netlify.app

pghorpade
pghorpade approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work 💯

@pghorpade pghorpade merged commit 49ad0af into vue3.x May 16, 2024
11 checks passed
@pghorpade pghorpade deleted the APPS-2665-bugfix-enable-search-on-clear branch May 16, 2024 18:27
pghorpade pushed a commit that referenced this pull request May 16, 2024
@semantic-release-bot
chore(release): set package.json to 2.39.0-alpha.79 [skip ci]
aff417d 
# [2.39.0-alpha.79](v2.39.0-alpha.78...v2.39.0-alpha.79) (2024-05-16)

### Bug Fixes

* APPS-2665 When user clicks the x on search keyword, the search is not triggered automatically ([#509](#509)) ([49ad0af](49ad0af))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 2.39.0-alpha.79 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pghorpade pghorpade pghorpade approved these changes

Assignees

@farosFreed farosFreed

Labels
bugfix Something isn't working released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@farosFreed @pghorpade