Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test completeness score #40

Merged
merged 32 commits into from May 16, 2024
Merged

feat: test completeness score #40

merged 32 commits into from May 16, 2024

Conversation

JohnShiuMK
Copy link
Collaborator

@JohnShiuMK JohnShiuMK commented May 7, 2024

part of the #39

@JohnShiuMK JohnShiuMK self-assigned this May 7, 2024
@JohnShiuMK JohnShiuMK changed the title 39 dev test score feat: test completeness score May 7, 2024
@JohnShiuMK JohnShiuMK added the enhancement New feature or request label May 7, 2024
@tonyshumlh tonyshumlh self-assigned this May 16, 2024
@tonyshumlh tonyshumlh marked this pull request as ready for review May 16, 2024 21:19
@tonyshumlh tonyshumlh removed their assignment May 16, 2024
@SoloSynth1
Copy link
Collaborator

SoloSynth1 commented May 16, 2024

@tonyshumlh If I understand correctly in the latest commit you just changed the code in notebook, and I need to update the python file to reflect that, is that right?

@tonyshumlh
Copy link
Collaborator

@SoloSynth1 you are correct

Copy link
Collaborator

@SoloSynth1 SoloSynth1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonyshumlh dependency problem. Do you want to add pandas as dependency?

src/test_creation/04_refactor-code.ipynb Show resolved Hide resolved
Copy link
Collaborator

@SoloSynth1 SoloSynth1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Admittedly we can refactor this, but I think this will work as a MVP for now.

Thanks @JohnShiuMK and @tonyshumlh

@JohnShiuMK JohnShiuMK merged commit 1044afc into main May 16, 2024
@JohnShiuMK JohnShiuMK deleted the 39-dev-test-score branch May 16, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment