Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add magic ✨ #223

Closed
wants to merge 29 commits into from
Closed

Add magic ✨ #223

wants to merge 29 commits into from

Conversation

Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Nov 23, 2023

No description provided.

@Tyrrrz Tyrrrz marked this pull request as draft November 23, 2023 17:26
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (1cfa50e) 94.98% compared to head (58d4143) 91.87%.

Files Patch % Lines
CliWrap.Immersive/Spells.cs 22.91% 37 Missing ⚠️
CliWrap.Immersive/Utils/Disposable.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   94.98%   91.87%   -3.12%     
==========================================
  Files          46       50       +4     
  Lines        1097     1169      +72     
  Branches       86       91       +5     
==========================================
+ Hits         1042     1074      +32     
- Misses         35       75      +40     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tyrrrz Tyrrrz added the wontfix label Jan 29, 2024
@Tyrrrz
Copy link
Owner Author

Tyrrrz commented Jan 29, 2024

Closing as it looks more and more like a solution in search of a problem

@Tyrrrz Tyrrrz closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant