Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto publish language-extensions #1483

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lolleko
Copy link
Member

@lolleko lolleko commented Sep 4, 2023

When. a release of the main package is created via npm version, the subpackage language-extensions will get bumped to the same version. Both will then be published to npm via GitHub Actions

Closes #1482

@Perryvw
Copy link
Member

Perryvw commented Sep 7, 2023

I see that in the tstl package.json we have a dependency on "@typescript-to-lua/language-extensions": "1.0.0". I guess we should also be bumping that version to match the new version.

I am worried that in that case the build order becomes very important. We could not build (npm install) the version bump commit because the packages are not yet available...

@lolleko
Copy link
Member Author

lolleko commented Sep 7, 2023

I see that in the tstl package.json we have a dependency on "@typescript-to-lua/language-extensions": "1.0.0". I guess we should also be bumping that version to match the new version.

I am worried that in that case the build order becomes very important. We could not build (npm install) the version bump commit because the packages are not yet available...

Good catch. I will think a bit about on how to solve this. AFAIK this dependency is only there to "force" users to download language-extensions alongside TSTL. My initial thoughts and possible solutions:

  1. Remove the dependency and let users install language-extensions manually if needed (not sure if that's good or not)
  2. Change the build order and do something like extension bump -> publish extensions -> tstl bump -> tstl publish. However, this will be difficult with our current setup as we do the bumping locally and releasing via action.
  3. Don't automate just do it manually as you did just now and use the script from the DotA monorepo.
    To ensure we don't forgot about releasing an language-extension update in the future we could write a GitHub action that warns us if language-extensions files have been modified without being released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LuaTable isEmpty() method not present in language-extensions.
2 participants