Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: twingateresourceaccess - allow specifying principal by name #62

Merged
merged 43 commits into from Mar 26, 2024
Merged

feat: twingateresourceaccess - allow specifying principal by name #62

merged 43 commits into from Mar 26, 2024

Conversation

ekampf
Copy link
Contributor

@ekampf ekampf commented Dec 8, 2023 •
edited

Related Tickets & Documents

Resolves #32

Changes

Adds support for principalExternalRef in the TwingateResourceAccess CRD.

apiVersion: twingate.com/v1beta
kind: TwingateResourceAccess
metadata:
  name: my-twingate-access
spec:
  resourceRef:
    name: my-twingate-resource
    namespace: default
  principalExternalRef:
    type: Group
    name: "my group"

@ekampf ekampf changed the title Feat: 32 feat twingateresourceaccess allow specifying principal by name feat: twingateresourceaccess - allow specifying principal by name Dec 19, 2023
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the wontfix This will not be worked on label Mar 13, 2024
@ekampf ekampf removed the wontfix This will not be worked on label Mar 14, 2024
@ekampf ekampf marked this pull request as ready for review March 15, 2024 20:59
@ekampf ekampf requested a review from minhtule March 20, 2024 00:29
minhtule
minhtule approved these changes Mar 21, 2024
View reviewed changes
Copy link

@minhtule minhtule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix & merge!

deploy/twingate-operator/crds/twingate.com.twingateresourceaccesses.yaml Outdated Show resolved Hide resolved
tests_integration/test_crds_resourceaccess.py Outdated Show resolved Hide resolved
tests_integration/test_resource_flows.py Outdated Show resolved Hide resolved
app/api/client.py Outdated Show resolved Hide resolved
app/api/client.py Outdated Show resolved Hide resolved
app/api/client_service_accounts.py Outdated Show resolved Hide resolved
deploy/twingate-operator/crds/twingate.com.twingateresourceaccesses.yaml Show resolved Hide resolved
app/handlers/handlers_resource_access.py Outdated Show resolved Hide resolved
app/handlers/handlers_resource_access.py Outdated Show resolved Hide resolved
app/tests/test_crds_resourceaccess.py
"fieldsV1": {
"f:spec": {
".": {},
"f:principalId": {},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be principalExternalRef? Or this metadata key is not used in the test? If so, maybe it's simpler to not include it 🤔

@coveralls
Copy link
Collaborator

coveralls commented Mar 22, 2024 •
edited

Pull Request Test Coverage Report for Build 8431132151

Details

  • 65 of 66 (98.48%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 97.495%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/crds.py 16 17 94.12%
Totals Coverage Status
Change from base Build 8431127607: -0.02%
Covered Lines: 856
Relevant Lines: 868
💛 - Coveralls

@ekampf ekampf merged commit 0b1e69b into main Mar 26, 2024
16 checks passed
@ekampf ekampf deleted the feature/32-feat-twingateresourceaccess-allow-specifying-principal-by-name branch March 26, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minhtule minhtule minhtule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: TwingateResourceAccess allow specifying principal by name
3 participants
@ekampf @coveralls @minhtule