Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: TwingateConnector - allow defining extra pod annotations with podAnnotations #225

Merged
merged 4 commits into from Mar 26, 2024
Merged

feat: TwingateConnector - allow defining extra pod annotations with podAnnotations #225

merged 4 commits into from Mar 26, 2024

Conversation

ekampf
Copy link
Contributor

@ekampf ekampf commented Mar 26, 2024

Related Tickets & Documents

Fixes #217

Changes

  • Add podAnnotations to TwingateConnector CRD
  • propagate annotations to created pod

@linear Linear
Copy link

linear bot commented Mar 26, 2024

OSS-24 Connector pod annotation configuration

@ekampf ekampf changed the title Add TwingateConnector.podAnnotations feat: TwingateConnector - allow defining extra pod annotations with podAnnotations Mar 26, 2024
@coveralls
Copy link
Collaborator

coveralls commented Mar 26, 2024 •
edited

Pull Request Test Coverage Report for Build 8441415675

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 97.5%
Totals Coverage Status
Change from base Build 8440877564: 0.005%
Covered Lines: 858
Relevant Lines: 870
💛 - Coveralls

minhtule
minhtule approved these changes Mar 26, 2024
View reviewed changes
Copy link

@minhtule minhtule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix & merge!

app/handlers/handlers_connectors.py Outdated Show resolved Hide resolved
@ekampf ekampf enabled auto-merge (squash) March 26, 2024 18:56
@ekampf ekampf merged commit 7b44838 into main Mar 26, 2024
16 checks passed
@ekampf ekampf deleted the feature/oss-24-connector-pod-annotation-configuration branch March 26, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minhtule minhtule minhtule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connector pod annotation configuration
3 participants
@ekampf @coveralls @minhtule