Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add validation for TwingateConnector when provider is “google” #224

Conversation

ekampf
Copy link
Contributor

@ekampf ekampf commented Mar 26, 2024

Related Tickets & Documents

Fixes #214

Changes

Added TwingateConnector CRD validation that forces defining repository if provider is google

Copy link

linear bot commented Mar 26, 2024

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8438901046

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.495%

Totals Coverage Status
Change from base Build 8431181226: 0.0%
Covered Lines: 856
Relevant Lines: 868

💛 - Coveralls

Copy link

@minhtule minhtule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ekampf ekampf merged commit 68e188e into main Mar 26, 2024
16 checks passed
@ekampf ekampf deleted the feature/oss-21-missing-misconfiguration-information-in-connector-resource branch March 26, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing misconfiguration information in connector resource
3 participants