New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow env to be defined in containerExtra #222

Merged

ekampf merged 3 commits into main from fix/oss-23-set-environment-variables-in-containerextra-breaks

Mar 26, 2024

Contributor

ekampf commented Mar 26, 2024 •

edited

Related Tickets & Documents

Fixes #216

Changes

Allow env to be defind in containerExtra and merge it with the pod env we set in our code


          allow env to be defined in containerExtra

9a75cb9

linear bot commented Mar 26, 2024

OSS-23 Set environment variables in containerExtra breaks deployment

ekampf added 2 commits

March 25, 2024 17:14


          fix tests

1bab7bc


          support envFrom too

6a23825

Collaborator

coveralls commented Mar 26, 2024 •

edited

Pull Request Test Coverage Report for Build 8428767708

Details

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 97.515%

Totals
Change from base Build 8428593795:	0.008%
Covered Lines:	799
Relevant Lines:	810

💛 - Coveralls

minhtule approved these changes

View reviewed changes

minhtule left a comment

LGTM 👍

ekampf merged commit 14f5ef5 into main

16 checks passed

ekampf deleted the fix/oss-23-set-environment-variables-in-containerextra-breaks branch

March 26, 2024 00:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment