Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Connector pod updates "Forbidden" error #184

Merged
merged 11 commits into from Mar 5, 2024
Merged

fix: Connector pod updates "Forbidden" error #184

merged 11 commits into from Mar 5, 2024

Conversation

ekampf
Copy link
Contributor

@ekampf ekampf commented Mar 5, 2024 •
edited by minhtule

Changes

If we change TwingateConnector properties (logLevel for example) we'll get the following error:

Forbidden: pod updates may not change fields other than `spec.containers[*].image

So this PR makes the following changes:

  1. Reconciler only checks the container image if pod exists
  2. When TwingateConnector updates we delete the pod and reconcile it

minhtule
minhtule approved these changes Mar 5, 2024
View reviewed changes
Copy link

@minhtule minhtule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Twingate Twingate deleted a comment from coveralls Mar 5, 2024
@ekampf ekampf merged commit 8096e62 into main Mar 5, 2024
12 checks passed
@ekampf ekampf deleted the feature/connector-reconcile-2 branch March 5, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minhtule minhtule minhtule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekampf @minhtule