Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improved twingate_connector_recreate_pod logic #179

Merged
merged 4 commits into from Mar 1, 2024
Merged

fix: Improved twingate_connector_recreate_pod logic #179

merged 4 commits into from Mar 1, 2024

Conversation

ekampf
Copy link
Contributor

@ekampf ekampf commented Mar 1, 2024

Changes

Improved twingate_connector_recreate_pod logic by using kopf.TemporaryError instead of a while loop to retry

@coveralls
Copy link
Collaborator

coveralls commented Mar 1, 2024 •
edited

Pull Request Test Coverage Report for Build 8114344550

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 96.516%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/handlers/handlers_connectors.py 8 10 80.0%
Totals Coverage Status
Change from base Build 8114244093: 0.9%
Covered Lines: 837
Relevant Lines: 858
💛 - Coveralls

@ekampf ekampf merged commit fd3f533 into main Mar 1, 2024
12 checks passed
@ekampf ekampf deleted the fix/twingate_connector_recreate_pod branch March 1, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekampf @coveralls