fix: Reduce update scope for twingate_resource_update
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8107348223Details
💛 - Coveralls |
minhtule
approved these changes
Mar 1, 2024
app/handlers/handlers_resource.py
Outdated
| crd = ResourceSpec(**new["spec"]) | ||
| crd = ResourceSpec(**spec) | ||
|
|
||
| if len(diff) == 1 and diff[0][0] == "add" and diff[0][1] == ("id",): |
There was a problem hiding this comment.
nit: I wonder if there is a nicer way to do this because the indexes are quite abstract. Maybe
if diff == (("add", ("id",), None, ANY),):? 🤔
There was a problem hiding this comment.
@minhtule I thought about it but ANY is in unittest which I wouldnt want to import on non testing code
…listens-to-too-many-updates
ekampf
deleted the
feature/oss-16-fix-twingate_resource_update-listens-to-too-many-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Tickets & Documents
Fixes #173
Changes
twingate_resource_updateshould only care whenspecupdates