Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@turf/boolean-valid] fix #checkClosingRing to check for polygon being closed #2563

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

superDoss
Copy link

@superDoss superDoss commented Jan 1, 2024

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

Currently the check if a ring is closed is using an OR condition which does not validate if the polygon is really closed, i've added a new test to check this and fixed the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant