Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for holes to @turf/mask #2346

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add support for holes to @turf/mask #2346

wants to merge 4 commits into from

Conversation

rowanwins
Copy link
Member

@rowanwins rowanwins commented Oct 9, 2022 •
edited

Currently @turf/mask ignores holes. The PR adds an options argument to the operation with an ignoreHoles option, when set to false a MultiPolygon is returned with the holes written as outer-rings in the MultiPolygon.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

Resolves #2230

@rowanwins rowanwins mentioned this pull request Oct 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect @turf/intersect result with polygon holes
1 participant
@rowanwins