Maintenance release for 2022 #594
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests are failing because ps is missing from the node base Docker image fix telemetry test looking for wrong value Update run.sh add output to sensor.sh for testing cat files to see what is being tested -putmetric in test_telemetry run.sh... because sensor.sh isn't working change metric name in -putmetric test put grep back into test_telemetry/run.sh
promhttp.Handler
len() for []interface{} is defined as zero
https://staticcheck.io/docs/checks#S1009
this type assertion to a variable (switch intv := intv.(type)) could eliminate type assertions in switch cases
*client: github.com/hashicorp/consul/api.Client contains sync.RWMutex
instead of fmt.Sprintf https://staticcheck.io/docs/checks#S1025
even if a function permits it; pass context.TODO if you are unsure about which Context to use https://staticcheck.io/docs/checks#SA1012
|
A successful CI run can be inspected here by the interested reader |
Use go version 1.19 as base image Bump consul version to 1.13.3 Update go.mod dependencies
TritonDataCenter#592 TritonDataCenter#593 All credits and thanks to Luc Willems Co-authored-by: Luc Willems <luc.willems@t-m-m.be>
Multiple: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (SA1019) discovery/consul_test.go:163:11: unnecessary use of fmt.Sprintf (S1039)
Support consul service meta data
find . -name '*' -type f -exec sed -i -e 's/joyent/tritondatacenter/g' -- {} +
|
I'm sorry for not having looked at this. There's a lot here. I've added myself and two others as reviewers. I see there are test results above, which may help us in making the decision to merge. I'm thinking it should be a series of smaller squashable-to-one-commit PRs, however, as that's how we normally roll (squish one PR into one commit). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make build lint integrationI know this is a big looking PR and I'd like to gather feedback whether upstream is interested in any of the changes.
If interested, I could also break this up into into several smaller ones, if that is preferred.
Feature changes include
Changelog
Incorporated several pull requests, adding one feature and fixing one issue:
Other notably bigger changes:
Lots of smaller changes, mainly maintenance related:
goversion to 1.17consulversion to 1.11.4staticcheckinstead of deprecatedgolintstaticchecklint changesgofmtSummaries:
Changes since last upstream release
3.8.03.8.0...greenbaum:3.8.4
Changes since last forked release
3.8.3greenbaum/containerpilot@3.8.3...greenbaum:3.8.4