Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows x86_64 CI (github actions) support. #29773

Merged
merged 3 commits into from
May 31, 2024

Conversation

Fabi
Copy link
Contributor

@Fabi Fabi commented Mar 2, 2024

Changes proposed:

  • Windows x86_64 CI support through github actions

This is only for the master branch.
It should finish in about 25 minutes most of the time. Sometimes around 20 minutes. That's way faster than appveyor!

Additional Info

  • I used the latest versions for boost and openssl. If you want some older, just change the link and install folder
  • I did set a retention period. Left it in the yml file just in case you want to specify it
  • I did not add a badge since you might want to port it to the other branches too. I only do it for master.
  • This is intended to replace appveyor.
  • Only one artifact with symbols is uploaded. If people use it and get crashes we want proper crash logs.

Notes for other branches:
335: branch requires copying the legacy dll. I did not test it there at all.
classic: Should work out of the box

Tests performed:

Tested with github actions on the master branch.

@jackpoz
Copy link
Member

jackpoz commented Mar 2, 2024

  • This is intended to replace appveyor.

We prefer to have different CIs so if one is down, we can rely on the others.

@Faq
Copy link
Contributor

Faq commented Mar 2, 2024

github services not often down. It is a few hours max, or what you meant?

@Aokromes
Copy link
Member

Aokromes commented Mar 2, 2024

  • This is intended to replace appveyor.

We prefer to have different CIs so if one is down, we can rely on the others.

maybe we can have both?

@Fabi
Copy link
Contributor Author

Fabi commented Mar 2, 2024

  • This is intended to replace appveyor.

We prefer to have different CIs so if one is down, we can rely on the others.

Then adding it as another CI for Windows should be fine no? Currently there are only advantages in doing that 🤔

One possibility is also to use one for artifact builds (stay at appveyor) and debug builds on gh actions like gcc/mac. That would down the compile time to about 15 mins for a windows ci

So in the end it would be like:

  • appveyor unchanged
  • this gh actions pr changed to debug and removing artifacts to not have to wait for 45 minute builds

Or the other way to save overall time :D

@Shauren Shauren merged commit 19232ed into TrinityCore:master May 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants