fix(useRenderLoop): allow separate instances POC #646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
useRenderLoop
currently spawns only a single loop used by all instances of<TresCanvas />
. Among other things, this means an individual canvas can't be paused without pausing all canvases:useRenderLoop
per page share state #252Solution
For a component subtree,
provide
/inject
a unique loop.Context
As discussed on the Discord, this is a POC preserving the current
useRenderLoop
interface, but with separate instances of the render loop per<TresCanvas />
. As with the current code, the POC works in<script setup>
above a<template><TresCanvas /></template>
.Current shortcomings
provide
/inject
. So http://localhost:5173/basic/lights doesn't work out of the box.I have a transparent-to-the-user solution in mind for 1. There could be a transparent or explicit workaround for 2, but I'd like to discuss these with the team on the Discord.
Taking over the render loop isn't implemented; I'd like to diverge from R3F's API here. I'll bring it up on the Discord.
Playground
pnpm run playground
Since this modifies
useRenderLoop
all the playground demos are using it. Except for directives, they all work, at least at first glance.