fix(core): add new launch.json and fixed breakpoints not working #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alvarosabu
requested changes
Mar 25, 2024
| : useElementSize(computed(() => toValue(canvas).parentElement)) | ||
| : useElementSize( | ||
| computed( | ||
| () => toValue(canvas).parentElement, |
There was a problem hiding this comment.
Hi @ThimoDEV why is this change needed?
There was a problem hiding this comment.
Hi @alvarosabu There is an issue when the TresCanvas uses the parent element width and height.
The usElementSize composable from VueUse loses its reactivity I assume which causes the TresCanvas width and height to be 0.
This issue occurs when you hit a breakpoint and continue debugging after. When you use the useWindowSize prop this doesn't happen.
This fixes that
alvarosabu
added
investigation
needs-test
p2-nice-to-have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new launch.json so a maintainer of TresJS can use breakpoints during development.
How to use?
pnpm playgroundRun and debugwindowI had this weird issue where the localhost url wasn't working. I set the port on all to 3000 which seems to make the dev server more stable. I don't know if this impacts releases in any way?