Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a plugin to strip string off the given characters #827

Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 9, 2023

Plugin that strips string from some characters (#804 )

  • Give the same name to the pull request as the name of ticket
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Test your code throughly before PR.
  • I hereby declare this contribution to be licenced under the MIT license

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2023

CLA assistant check
All committers have signed the CLA.

@atompie atompie merged commit 0238923 into Tracardi:0.8.2-dev Oct 10, 2023
1 check passed
@atompie
Copy link
Collaborator

atompie commented Oct 10, 2023

@kokobhara Merged and works as expected

Screenshot from 2023-10-10 08-55-52

@atompie
Copy link
Collaborator

atompie commented Oct 10, 2023

@kokobhara If you would like also to add documentation for it I created a task. #828

@ghost
Copy link
Author

ghost commented Oct 10, 2023

Sure, I'll take that up.

@ghost ghost deleted the 804-plugin-to-strip-characters branch October 10, 2023 07:05
@atompie
Copy link
Collaborator

atompie commented Oct 10, 2023

@kokobhara You have to comment on #828 so I can assign you. Thnaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants