Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imx8qm support. #226

Open
wants to merge 2 commits into
base: released
Choose a base branch
from
Open

Conversation

unbel13ver
Copy link

No description provided.

Signed-off-by: Ivan Nikolaenko <ivan.nikolaenko@unikie.com>
Features:
* ATF + OP-TEE support included
* The groundwork for all i.MX8 family

Limitations:
* No HDMI support (HDMI fw is not embedded into boot
container)
* Only USB boot is supported (I could not test other devices)

Signed-off-by: Ivan Nikolaenko <ivan.nikolaenko@unikie.com>
@samueldr
Copy link
Contributor

samueldr commented Jul 2, 2023

Hi! 👋

First of all, sorry for taking a while until coming back to this PR.

At first glance a lot of it looks okay, like your comments about needing to generalize: when adding a new family, it often happens that we don't have enough knowledge floating about to correctly generalize, so as long as the inputs and outputs are correct enough to handle generalizing later without much pain, I think it's likely fine.

Since this is adding a new family outright, I'm pushing this in the next release.

I will also evaluate and compare with the WIP-yet-untested branch I had for the Librem 5, which built with what looked like probably working outputs. And then try to guesstimate some of the generalization and get back around to you for seeing if you can judge whether the changes are okay or not.

Though one really problematic part here: reliance on a vendor fork of U-Boot. That will require thinking about how to handle: we don't have the capacity to track more than one upstream. Ideally, we'd see how that is custom is needed for a support level similar to the other boards (e.g., no fancy TF-A, OP-TEE) and see if forward porting to mainline and maybe working with them to contribute that subset would be feasible. But that's something to evaluate later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants