Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix TIFFWSIReader read_bound #777

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

vqdang
Copy link
Contributor

@vqdang vqdang commented Jan 29, 2024

image

Emergency bugfix per @John-P request.
The culprit is reading bound doesn't use the adjusted bounds as have been done in OpenSlideReader

@shaneahmed shaneahmed added the bug Something isn't working label Feb 2, 2024
@shaneahmed shaneahmed added this to the Release v1.5.2 milestone Feb 2, 2024
@shaneahmed shaneahmed changed the title BUG: Fix TIFFWSIReader read bound 🐛 Fix TIFFWSIReader read_bound Feb 2, 2024
@shaneahmed
Copy link
Member

Thanks @vqdang and @John-P Please can you add a simple test to make sure this produces expected results.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.89%. Comparing base (3da5ca2) to head (13d3293).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #777   +/-   ##
========================================
  Coverage    99.89%   99.89%           
========================================
  Files           69       69           
  Lines         8588     8588           
  Branches      1645     1645           
========================================
  Hits          8579     8579           
  Misses           1        1           
  Partials         8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaneahmed shaneahmed linked an issue Feb 2, 2024 that may be closed by this pull request
@shaneahmed
Copy link
Member

Please can you also check if it is related to #499 ?

@Abdol
Copy link
Collaborator

Abdol commented May 13, 2024

I have added a simple test but not completely sure if it fully tests for the fixed bug. @vqdang @John-P I'd appreciate it if you can give the test a review.

@Abdol Abdol self-assigned this May 14, 2024
@Abdol Abdol requested a review from John-P May 14, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with TIFFWSIReader
3 participants